[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards |
Date: |
Wed, 19 Jun 2019 21:13:51 +1000 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Fri, Jun 14, 2019 at 01:08:44PM +0200, Greg Kurz wrote:
> There are several places where CONFIG_KVM is used to guard code that
> should only be built when KVM is supported. It is generally preferable
> to avoid that and leave such guards in header files for improved
> readability.
>
> In many cases, the execution of the code is also conditionned by
> kvm_enabled() which expands to (0) when CONFIG_KVM is not defined.
> This is likely to cause the compiler to optimize the code out,
> and if it doesn't, the right way to address compiling issues is
> to add stubs.
>
> Successfuly compile tested on x86_64 and ppc64le linux. Travis shows
> this builds fine on OSX as well.
1..5 applied. Still need to look at 6..7 more closely.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 6/7] ppc: Introduce kvmppc_set_reg_tb_offset() helper, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 7/7] target/ppc/machine: Add kvmppc_pvr_workaround_required() stub, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 5/7] hw/ppc: Drop useless CONFIG_KVM ifdefery, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 4/7] hw/ppc/prep: Drop useless CONFIG_KVM ifdefery, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 3/7] hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 2/7] hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery, Greg Kurz, 2019/06/14
- [Qemu-devel] [PATCH 1/7] spapr_pci: Drop useless CONFIG_KVM ifdefery, Greg Kurz, 2019/06/14
- Re: [Qemu-devel] [PATCH 0/7] ppc: Get rid of some CONFIG_KVM guards,
David Gibson <=