Re: [Qemu-devel] [PATCH v11 0/5] linux-user: A set of miscellaneous patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v11 0/5] linux-user: A set of miscellaneous patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2cb11dc278 linux-user: Fix flock structure for MIPS O64 ABI
9b46ad1d74 linux-user: Add support for strace for statx() syscall
f07e73c4e8 linux-user: Add support for translation of statx() syscall
7cd06556e2 linux-user: Add support for setsockopt() option SOL_ALG
ff013fd21e linux-user: Add support for setsockopt() options 
IPV6_<ADD|DROP>_MEMBERSHIP

=== OUTPUT BEGIN ===
1/5 Checking commit ff013fd21e8a (linux-user: Add support for setsockopt() 
options IPV6_<ADD|DROP>_MEMBERSHIP)
2/5 Checking commit 7cd06556e2a8 (linux-user: Add support for setsockopt() 
option SOL_ALG)
3/5 Checking commit f07e73c4e886 (linux-user: Add support for translation of 
statx() syscall)
WARNING: architecture specific defines should be avoided
#60: FILE: linux-user/syscall.c:323:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#72: FILE: linux-user/syscall.c:6529:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#142: FILE: linux-user/syscall.c:10239:
+#if defined(__NR_statx)

total: 0 errors, 3 warnings, 207 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 9b46ad1d741e (linux-user: Add support for strace for 
statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {

ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {

total: 2 errors, 0 warnings, 104 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 2cb11dc27883 (linux-user: Fix flock structure for MIPS O64 
ABI)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden