[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 7/9] target/i386: Support multi-dies when hos
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 7/9] target/i386: Support multi-dies when host doesn't support CPUID.1F |
Date: |
Thu, 20 Jun 2019 00:29:01 -0300 |
On Thu, Jun 20, 2019 at 10:03:07AM +0800, Like Xu wrote:
> On 2019/6/20 7:36, Eduardo Habkost wrote:
> > On Wed, Jun 19, 2019 at 04:15:46PM -0300, Eduardo Habkost wrote:
> > > On Wed, Jun 12, 2019 at 04:41:02PM +0800, Like Xu wrote:
> > > > In guest CPUID generation process, the cpuid_min_level would be
> > > > adjusted to
> > > > the maximum passed value for basic CPUID configuration and it should
> > > > not be
> > > > restricted by the limited value returned from cpu_x86_cpuid(). After
> > > > the basic
> > > > cpu_x86_cpuid() loop is finished, the cpuid_0_entry.eax needs to be
> > > > configured
> > > > again by the last adjusted cpuid_min_level value.
> > > >
> > > > If a user wants to expose CPUID.1F by passing dies > 1 for any reason
> > > > without
> > > > host support, a per-cpu smp topology warning will appear but it's not
> > > > blocked.
> > > >
> > > > Signed-off-by: Like Xu <address@hidden>
> > >
> > > This code doesn't look at host CPUID at all, as far as I can see.
> > > Isn't it simpler to just make cpuid_x86_cpuid() return the
> > > correct data?
> >
> > I suggest the following change instead.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Hi Eduardo,
>
> Your code is more reasonable and concise than mine on this
> so let's not break cpuid_x86_cpuid().
>
> I'll remove the use of enable_cpuid_0x1f in next version, and should I
> resend the patch series "Refactor cpu topo into machine properties" because
> rebase-fix may distract you ?
"Refactor cpu topo" and patches 1-4 of this series are already
queued on my machine-next branch. You can send the next version
of the series using that branch as base:
https://github.com/ehabkost/qemu.git machine-next
--
Eduardo
[Qemu-devel] [PATCH v3 2/9] hw/i386: Adjust nr_dies with configured smp_dies for PCMachine, Like Xu, 2019/06/12
[Qemu-devel] [PATCH v3 5/9] tests/x86-cpuid: Update testcases in test_topo_bits() with multiple dies, Like Xu, 2019/06/12
[Qemu-devel] [PATCH v3 3/9] i386/cpu: Consolidate die-id validity in smp context, Like Xu, 2019/06/12
[Qemu-devel] [PATCH v3 4/9] i386: Update new x86_apicid parsing rules with die_offset support, Like Xu, 2019/06/12
[Qemu-devel] [PATCH v3 6/9] i386/cpu: Add CPUID.1F generation support for multi-dies PCMachine, Like Xu, 2019/06/12