Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v4 0/8] Add Qemu to SeaBIOS LCHS interface

[Sam Eiderman]

> On 20 Jun 2019, at 8:50, Gerd Hoffmann <address@hidden> wrote:
> 
>> === OUTPUT BEGIN ===
>> 1/8 Checking commit cf2168a66dbd (block: Refactor macros - fix tabbing)
>> ERROR: Macros with complex values should be enclosed in parenthesis
>> #55: FILE: include/hw/block/block.h:65:
>> +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
>> +    DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
>> +    DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
>>     DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
> 
> False positive.
> 
>> 8/8 Checking commit 6664d7d898d5 (hd-geo-test: Add tests for lchs override)
>> WARNING: line over 80 characters
>> #242: FILE: tests/hd-geo-test.c:579:
>> +                     (char *)r->dev_path, &(r->chs.c), &(r->chs.h), 
>> &(r->chs.s));
> 
> Should be fixed.

I’ll resubmit.

Sam

> 
>> WARNING: Block comments use a leading /* on a separate line
>> #640: FILE: tests/hd-geo-test.c:995:
>> +                       "skipping hd-geo/override/* tests");
> 
> False positive too.
> 
> cheers,
>  Gerd
>