[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump" |
Date: |
Mon, 24 Jun 2019 13:31:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes:
> On Wed, Jun 19, 2019 at 10:10:49PM +0200, Markus Armbruster wrote:
>> Commit 2da91b54fe9 "dump: add Windows dump format to
>> dump-guest-memory" neglected to update MAINTAINERS. Do it now.
>>
>> Cc: Marc-André Lureau <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> MAINTAINERS | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a3fdda015f..327ad80ae4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1850,9 +1850,10 @@ F: include/sysemu/device_tree.h
>> Dump
>> S: Supported
>> M: Marc-André Lureau <address@hidden>
>> -F: dump/dump.c
>> +F: dump/
>
> Isn't this better squashed in the previous patch in fact.
If I do that, the commit does two things: move code and improve
MAINTAINERS coverage. Okay in this case. We can just as well finish
the improvement job then, i.e. squash the entire commit into the
previous one.
>> F: hw/misc/vmcoreinfo.c
>> F: include/hw/misc/vmcoreinfo.h
>> +F: include/qemu/win_dump_defs
>> F: include/sysemu/dump-arch.h
>> F: include/sysemu/dump.h
>> F: qapi/dump.json
>
> Either way, the result is good so
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 00/17] Move QOM, qdev, machine core and dump code, Markus Armbruster, 2019/06/19
- [Qemu-devel] [PATCH 02/17] Makefile: Don't add monitor/ twice to common-obj-y, Markus Armbruster, 2019/06/19
- [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump", Markus Armbruster, 2019/06/19
- [Qemu-devel] [PATCH 07/17] MAINTAINERS: Merge sections CPU, NUMA into Machine core, Markus Armbruster, 2019/06/19
- [Qemu-devel] [PATCH 09/17] hw/core: Move numa.c to hw/core/, Markus Armbruster, 2019/06/19
- [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM, Markus Armbruster, 2019/06/19