Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

[Daniel P . Berrangé]

On Mon, Jun 24, 2019 at 01:19:33PM +0200, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
> 
> > On 19/06/19 22:10, Markus Armbruster wrote:
> >> Move commands device-list-properties, device_add, device-del, and
> >> event DEVICE_DELETED from misc.json to new qdev.json.  qdev.json
> >> remains uncovered by MAINTAINERS, like the rest of qdev.
> >
> > qdev should be added to either QOM or machine core.  QOM would be fine
> > for me as the (newly,self)-appointed maintainer.
> 
> Awesome!  Daniel, Eduardo, any objections?
> 
> I figure these are the files to add:
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 63390eadb5..e2cb1726dd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2033,12 +2033,18 @@ M: Paolo Bonzini <address@hidden>
>  R: Daniel P. Berrange <address@hidden>
>  R: Eduardo Habkost <address@hidden>
>  S: Supported
> +F: docs/qdev-device-use.txt
> +F: hw/core/qdev*
> +F: include/hw/qdev*
> +F: include/monitor/qdev.h
>  F: include/qom/
>  X: include/qom/cpu.h
> +F: qdev-monitor.c
>  F: qom/
>  X: qom/cpu.c
>  F: tests/check-qom-interface.c
>  F: tests/check-qom-proplist.c
> +F: tests/test-qdev-global-props.c
>  
>  QMP
>  M: Markus Armbruster <address@hidden>

For this addition

Reviewed-by: Daniel P. Berrangé <address@hidden>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|