Re: [Qemu-devel] [PATCH v13 0/5] linux-user: A set of miscellaneous patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v13 0/5] linux-user: A set of miscellaneous patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f092e1d linux-user: Handle EXCP_FPE properly for MIPS
27e9bdd linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK
475d61c linux-user: Fix flock structure for MIPS O64 ABI
ae7dbb4 linux-user: Add support for strace for statx() syscall
3956339 linux-user: Add support for translation of statx() syscall

=== OUTPUT BEGIN ===
1/5 Checking commit 39563390d2d9 (linux-user: Add support for translation of 
statx() syscall)
WARNING: architecture specific defines should be avoided
#60: FILE: linux-user/syscall.c:322:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#72: FILE: linux-user/syscall.c:6479:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#142: FILE: linux-user/syscall.c:10189:
+#if defined(__NR_statx)

total: 0 errors, 3 warnings, 186 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit ae7dbb4c21bf (linux-user: Add support for strace for 
statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {

ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {

total: 2 errors, 0 warnings, 104 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 475d61cbdb89 (linux-user: Fix flock structure for MIPS O64 
ABI)
4/5 Checking commit 27e9bdd1e949 (linux-user: Introduce 
TARGET_HAVE_ARCH_STRUCT_FLOCK)
5/5 Checking commit f092e1d90322 (linux-user: Handle EXCP_FPE properly for MIPS)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden