[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] block/qcow: Improve error when opening qcow2 fil
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 4/6] block/qcow: Improve error when opening qcow2 files as qcow |
Date: |
Mon, 8 Jul 2019 16:18:10 +0200 |
From: John Snow <address@hidden>
Reported-by: address@hidden
Fixes: https://bugs.launchpad.net/bugs/1832914
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Maxim Levitsky <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/qcow.c b/block/qcow.c
index 6dee5bb792..5bdf72ba33 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options,
int flags,
goto fail;
}
if (header.version != QCOW_VERSION) {
- error_setg(errp, "Unsupported qcow version %" PRIu32, header.version);
+ error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32,
+ QCOW_VERSION, header.version);
+ if (header.version == 2 || header.version == 3) {
+ error_append_hint(errp, "Try the 'qcow2' driver instead.\n");
+ }
+
ret = -ENOTSUP;
goto fail;
}
--
2.20.1
- [Qemu-devel] [PULL 0/6] Block layer patches, Kevin Wolf, 2019/07/08
- [Qemu-devel] [PULL 5/6] MAINTAINERS: update RBD block maintainer, Kevin Wolf, 2019/07/08
- [Qemu-devel] [PULL 1/6] vl: add qemu_add_vm_change_state_handler_prio(), Kevin Wolf, 2019/07/08
- [Qemu-devel] [PULL 3/6] virtio-scsi: restart DMA after iothread, Kevin Wolf, 2019/07/08
- [Qemu-devel] [PULL 4/6] block/qcow: Improve error when opening qcow2 files as qcow,
Kevin Wolf <=
- [Qemu-devel] [PULL 2/6] qdev: add qdev_add_vm_change_state_handler(), Kevin Wolf, 2019/07/08
- [Qemu-devel] [PULL 6/6] qcow2: Allow -o compat=v3 during qemu-img amend, Kevin Wolf, 2019/07/08
- Re: [Qemu-devel] [PULL 0/6] Block layer patches, Peter Maydell, 2019/07/08