[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition |
|
Date: |
Fri, 12 Jul 2019 19:05:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/12/19 9:35 AM, Pankaj Gupta wrote:
> Coverity reported memory region returns zero
> for non-null value. This is because of wrong
> arguments to '?:' , fixing this.
>
Please amend:
Fixes: Coverity (CID 1403009)
> Signed-off-by: Pankaj Gupta <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/virtio/virtio-pmem-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c
> index 8b2d0dbccc..0da6627469 100644
> --- a/hw/virtio/virtio-pmem-pci.c
> +++ b/hw/virtio/virtio-pmem-pci.c
> @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const
> MemoryDeviceState *md,
> MemoryRegion *mr = vpc->get_memory_region(pmem, errp);
>
> /* the plugged size corresponds to the region size */
> - return mr ? 0 : memory_region_size(mr);
> + return mr ? memory_region_size(mr) : 0;
> }
>
> static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md,
>