[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] linux-user: fix to handle variably sized SIO
|
From: |
Arnd Bergmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v5] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels |
|
Date: |
Sun, 14 Jul 2019 20:29:06 +0200 |
On Sun, Jul 14, 2019 at 3:54 PM Laurent Vivier <address@hidden> wrote:
>
> From: Daniel P. Berrangé <address@hidden>
>
> The SIOCGSTAMP symbol was previously defined in the
> asm-generic/sockios.h header file. QEMU sees that header
> indirectly via sys/socket.h
>
> In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115
> the asm-generic/sockios.h header no longer defines SIOCGSTAMP.
> Instead it provides only SIOCGSTAMP_OLD, which only uses a
> 32-bit time_t on 32-bit architectures.
>
> The linux/sockios.h header then defines SIOCGSTAMP using
> either SIOCGSTAMP_OLD or SIOCGSTAMP_NEW as appropriate. If
> SIOCGSTAMP_NEW is used, then the tv_sec field is 64-bit even
> on 32-bit architectures
>
> To cope with this we must now convert the old and new type from
> the target to the host one.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
Looks good to me now
Reviewed-by: Arnd Bergmann <address@hidden>