[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: Use blk_truncate_for_fo
From: |
Maxim Levitsky |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: Use blk_truncate_for_formatting() |
Date: |
Tue, 16 Jul 2019 16:08:50 +0300 |
On Fri, 2019-07-12 at 19:35 +0200, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/parallels.c | 2 +-
> block/qcow.c | 2 +-
> block/qcow2.c | 2 +-
> block/qed.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 00fae125d1..a17b2d92f2 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -563,7 +563,7 @@ static int coroutine_fn
> parallels_co_create(BlockdevCreateOptions* opts,
> blk_set_allow_write_beyond_eof(blk, true);
>
> /* Create image format */
> - ret = blk_truncate(blk, 0, PREALLOC_MODE_OFF, errp);
> + ret = blk_truncate_for_formatting(blk, 0, errp);
> if (ret < 0) {
> goto out;
> }
> diff --git a/block/qcow.c b/block/qcow.c
> index 5bdf72ba33..86034135f9 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -858,7 +858,7 @@ static int coroutine_fn
> qcow_co_create(BlockdevCreateOptions *opts,
> blk_set_allow_write_beyond_eof(qcow_blk, true);
>
> /* Create image format */
> - ret = blk_truncate(qcow_blk, 0, PREALLOC_MODE_OFF, errp);
> + ret = blk_truncate_for_formatting(qcow_blk, 0, errp);
> if (ret < 0) {
> goto exit;
> }
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 039bdc2f7e..f3e53c781d 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3184,7 +3184,7 @@ qcow2_co_create(BlockdevCreateOptions *create_options,
> Error **errp)
> blk_set_allow_write_beyond_eof(blk, true);
>
> /* Clear the protocol layer and preallocate it if necessary */
> - ret = blk_truncate(blk, 0, PREALLOC_MODE_OFF, errp);
> + ret = blk_truncate_for_formatting(blk, 0, errp);
> if (ret < 0) {
> goto out;
> }
> diff --git a/block/qed.c b/block/qed.c
> index 77c7cef175..ec244158b5 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -673,7 +673,7 @@ static int coroutine_fn
> bdrv_qed_co_create(BlockdevCreateOptions *opts,
> l1_size = header.cluster_size * header.table_size;
>
> /* File must start empty and grow, check truncate is supported */
> - ret = blk_truncate(blk, 0, PREALLOC_MODE_OFF, errp);
> + ret = blk_truncate_for_formatting(blk, 0, errp);
> if (ret < 0) {
> goto out;
> }
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
- [Qemu-devel] [PATCH 0/7] block: Generic file creation fallback, Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 1/7] block/nbd: Fix hang in .bdrv_close(), Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 2/7] block: Add blk_truncate_for_formatting(), Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 3/7] block: Use blk_truncate_for_formatting(), Max Reitz, 2019/07/12
- Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] block: Use blk_truncate_for_formatting(),
Maxim Levitsky <=
- [Qemu-devel] [PATCH 4/7] block: Generic file creation fallback, Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 5/7] file-posix: Drop hdev_co_create_opts(), Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 6/7] iscsi: Drop iscsi_co_create_opts(), Max Reitz, 2019/07/12
- [Qemu-devel] [PATCH 7/7] iotests: Add test for image creation fallback, Max Reitz, 2019/07/12