[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] hw/i386/pc: Map into memory the initrd
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] hw/i386/pc: Map into memory the initrd |
Date: |
Tue, 23 Jul 2019 16:47:25 +0200 |
User-agent: |
NeoMutt/20180716 |
On Tue, Jul 23, 2019 at 04:30:17PM +0200, Paolo Bonzini wrote:
> On 23/07/19 16:04, Stefano Garzarella wrote:
> > In order to reduce the memory footprint we map into memory
> > the initrd using g_mapped_file_new() instead of reading it.
> > In this way we can share the initrd pages between multiple
> > instances of QEMU.
> >
> > Suggested-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Stefano Garzarella <address@hidden>
>
> Coverity is going to complain about the leaks. Should we instead store
> the initrd GMappedFile in PCMachineState, even if it is just for reference?
>
Yes, I'll put it in the PCMachineState.
Thanks,
Stefano