|
| From: | Thomas Huth |
| Subject: | Re: [Qemu-devel] [PATCH 01/36] i2c: Move typedef of bitbang_i2c_interface to i2c.h |
| Date: | Tue, 23 Jul 2019 21:01:27 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 23/07/2019 20.57, BALATON Zoltan wrote:
> On Tue, 23 Jul 2019, Michael Roth wrote:
>> From: BALATON Zoltan <address@hidden>
>>
>> Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and
>> bitbang_i2c.h an error even if they are identical. Move it to a common
>> place to allow building with this clang version.
>>
>> Reported-by: Thomas Huth <address@hidden>
>> Signed-off-by: BALATON Zoltan <address@hidden>
>> Acked-by: David Gibson <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> Signed-off-by: Thomas Huth <address@hidden>
>> (cherry picked from commit 2b4c1125ac3db2734222ff43c25388a16aca4a99)
>
> This was superseded by d718b7475 later so you may want to look at that
> instead but for stable branch I'm not sure what are your preferences.
You could also cherry-pick this commit here instead:
e6e90feedb706b1b92827a5977b37e1e8defb8ef
"configure: Add -Wno-typedef-redefinition to CFLAGS (for Clang)"
... this should fix this problem for good.
Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |