[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.2 11/14] replay: fix replay shutdown
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH for-4.2 11/14] replay: fix replay shutdown |
Date: |
Wed, 24 Jul 2019 11:44:15 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch fixes shutdown of the replay process, which is terminated with
the assert when shutdown event is read from the log.
replay_finish_event reads new data_kind and therefore the value of data_kind
should be preserved to be valid at qemu_system_shutdown_request call.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/replay/replay.c b/replay/replay.c
index df019c51ad..73c5d4e207 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -45,14 +45,14 @@ bool replay_next_event_is(int event)
}
while (true) {
- if (event == replay_state.data_kind) {
+ unsigned int data_kind = replay_state.data_kind;
+ if (event == data_kind) {
res = true;
}
- switch (replay_state.data_kind) {
+ switch (data_kind) {
case EVENT_SHUTDOWN ... EVENT_SHUTDOWN_LAST:
replay_finish_event();
- qemu_system_shutdown_request(replay_state.data_kind -
- EVENT_SHUTDOWN);
+ qemu_system_shutdown_request(data_kind - EVENT_SHUTDOWN);
break;
default:
/* clock, time_t, checkpoint and other events */
- [Qemu-devel] [PATCH for-4.2 03/14] replay: disable default snapshot for record/replay, (continued)
- [Qemu-devel] [PATCH for-4.2 03/14] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 04/14] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 05/14] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 06/14] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 07/14] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 08/14] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 09/14] replay: document development rules, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 10/14] util/qemu-timer: refactor deadline calculation for external timers, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 11/14] replay: fix replay shutdown,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH for-4.2 12/14] replay: refine replay-time module, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 13/14] replay: rename step-related variables and functions, Pavel Dovgalyuk, 2019/07/24
- [Qemu-devel] [PATCH for-4.2 14/14] icount: clean up cpu_can_io before jumping to the next block, Pavel Dovgalyuk, 2019/07/24
- Re: [Qemu-devel] [PATCH for-4.2 00/14] Some record/replay fixes, Paolo Bonzini, 2019/07/24