[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface |
Date: |
Thu, 25 Jul 2019 21:42:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 07/25/19 02:50, John Snow wrote:
>
>
> On 7/24/19 8:47 PM, John Snow wrote:
>>
>>
>> On 7/19/19 6:10 AM, Sam Eiderman wrote:
>>> Well, this patch introduces 3 command line parameters (“lcyls”, “lheads”,
>>> “lsecs”)
>>> to “scsi-hd” “ide-hd” and “virtio-pci-blk” so this somehow has something to
>>> do with
>>> block.
>>>
>>> This patch also adds fw_cfg interface to send these parameters to SeaBIOS.
>>>
>>> "scripts/get_maintainer.pl -f hw/nvram/fw_cfg.c” gives
>>>
>>> "Philippe Mathieu-Daudé" <address@hidden> (supporter:Firmware configur...)
>>> Laszlo Ersek <address@hidden> (reviewer:Firmware configur...)
>>> Gerd Hoffmann <address@hidden> (reviewer:Firmware configur…)
>>>
>>> And this was already Reviewed-by Gerd.
>>>
>>> How should I proceed?
>>>
>>> Sam
>>>
>>
>> I feel like it would be up to Gerd as the general SeaBIOS point of contact?
>>
>
> ...ah, who is offline for vacation.
>
> We're in freeze right now anyway, so I would think that Gerd and/or
> Kevin can work out who ought to stage this for a PR when the tree opens
> again.
>
I think the sole patch in the series that modifies "hw/nvram/fw_cfg.c" is
[Qemu-devel] [QEMU] [PATCH v5 7/8] bootdevice: FW_CFG interface for LCHS values
http://mid.mail-archive.com/address@hidden
and neither Phil nor myself seem to be CC'd on it (I've found the message in my
list folder only).
Regarding fw_cfg, I only review Phil's fw_cfg patches (so that whenever he
posts patches, he can count on my review); other than that, I generally skip
fw_cfg patches. And, I totally don't have a tree for collecting such patches.
Now, while Phil does:
T: git https://github.com/philmd/qemu.git fw_cfg-next
I still don't think that tree would be the best for queueing this series, given
the diffstat:
bootdevice.c | 148 +++++++++---
hw/block/virtio-blk.c | 6 +
hw/ide/qdev.c | 7 +-
hw/nvram/fw_cfg.c | 14 +-
hw/scsi/scsi-bus.c | 15 ++
hw/scsi/scsi-disk.c | 14 ++
include/hw/block/block.h | 22 +-
include/hw/scsi/scsi.h | 1 +
include/sysemu/sysemu.h | 4 +
tests/Makefile.include | 2 +-
tests/hd-geo-test.c | 582 +++++++++++++++++++++++++++++++++++++++++++++++
11 files changed, 774 insertions(+), 41 deletions(-)
Just my two cents.
Thanks
Laszlo
- Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Gerd Hoffmann, 2019/07/01
- Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/07/08
- Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/07/17
- Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Kevin Wolf, 2019/07/17
- Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/07/19
- Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, John Snow, 2019/07/24
- Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, John Snow, 2019/07/24
- Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface,
Laszlo Ersek <=
- Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface, Gerd Hoffmann, 2019/07/30