[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 4.1?] pl330: fix vmstate description
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for 4.1?] pl330: fix vmstate description |
Date: |
Fri, 26 Jul 2019 10:51:01 +0100 |
On Thu, 25 Jul 2019 at 17:14, Peter Maydell <address@hidden> wrote:
>
> On Wed, 24 Jul 2019 at 15:36, Damien Hedde <address@hidden> wrote:
> >
> > Fix the pl330 main and queue vmstate description.
> > There were missing POINTER flags causing crashes during
> > incoming migration because:
> > + PL330State chan field is a pointer to an array
> > + PL330Queue queue field is a pointer to an array
> >
> > Also bump corresponding vmsd version numbers.
> >
> > Signed-off-by: Damien Hedde <address@hidden>
> > ---
> >
> > I found this while working on reset with xilinx-zynq machine.
> >
> > I'm not sure what's the vmsd version policy in such cases (for
> > backward compatibility). I've simply bumped them since migration
> > was not working anyway (vmstate_load_state was erasing critical part
> > of PL330State and causing segfaults while loading following fields).
> >
> > Tested doing migration with the xilinx-zynq-a9 machine.
>
> Reviewed-by: Peter Maydell <address@hidden>
and applied to target-arm.next for 4.1.
thanks
-- PMM