[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio c
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks" |
|
Date: |
Tue, 30 Jul 2019 14:47:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/30/19 1:37 PM, Paolo Bonzini wrote:
> On 30/07/19 11:54, Philippe Mathieu-Daudé wrote:
>> Hi John,
>>
>> On 7/30/19 12:36 AM, John Snow wrote:
>>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.
>>>
>>> It's not correct to just ignore an error code in a callback; we need to
>>> handle that error and possible report failure to the guest so that they
>>> don't wait indefinitely for an operation that will now never finish.
>>
>> Is this 4.1 material? It looks so.
>
> Perhaps could have been last week, but now I suggest Cc qemu-stable and
> delaying it to 4.2.
I was wondering because Kevin was preparing a block@ pull request.
Anyway this seems fair because the reverted commit is dated from 2014.
Thanks,
Phil.