[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/28] queue: Drop superfluous #include qemu/ato
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 05/28] queue: Drop superfluous #include qemu/atomic.h |
Date: |
Wed, 31 Jul 2019 12:54:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 26/07/2019 14.05, Markus Armbruster wrote:
> When commit 5f7d05ecfda added QLIST_INSERT_HEAD_RCU() to qemu/queue.h,
> it had to include qemu/atomic.h. Commit 341774fe6cc removed
> QLIST_INSERT_HEAD_RCU() again, but neglected to remove the #include.
> Do that now.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/qemu/queue.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/qemu/queue.h b/include/qemu/queue.h
> index 0379bd8fdb..73bf4a984d 100644
> --- a/include/qemu/queue.h
> +++ b/include/qemu/queue.h
> @@ -78,8 +78,6 @@
> * For details on the use of these macros, see the queue(3) manual page.
> */
>
> -#include "qemu/atomic.h" /* for smp_wmb() */
> -
> /*
> * List definitions.
> */
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 00/28] Tame a few "touch this, recompile the world" headers, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 10/28] ide: Include hw/ide/internal a bit less outside hw/ide/, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 17/28] Include qom/object.h slightly less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 03/28] qapi: Split error.json off common.json, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 09/28] Include migration/qemu-file-types.h a lot less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 27/28] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 05/28] queue: Drop superfluous #include qemu/atomic.h, Markus Armbruster, 2019/07/26
- Re: [Qemu-devel] [PATCH 05/28] queue: Drop superfluous #include qemu/atomic.h,
Thomas Huth <=
- [Qemu-devel] [PATCH 02/28] Include generated QAPI headers less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 06/28] trace: Eliminate use of TARGET_FMT_plx, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 24/28] Include sysemu/hostmem.h less, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 11/28] typedefs: Separate incomplete types and function types, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 13/28] Clean up inclusion of exec/cpu-common.h, Markus Armbruster, 2019/07/26
- [Qemu-devel] [PATCH 25/28] numa: Move remaining NUMA declarations from sysemu.h to numa.h, Markus Armbruster, 2019/07/26