[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less |
Date: |
Wed, 7 Aug 2019 19:11:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/6/19 5:14 PM, Markus Armbruster wrote:
> hw/hw.h used to include headers hardware emulation "usually" needs.
> The previous commits removed all but one of them, to good effect.
> Only qom/object.h is left. Remove that one, too.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/display/edid.h | 2 +-
> include/hw/hw.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
> index 7948bd2c40..ff99dc0a05 100644
> --- a/include/hw/display/edid.h
> +++ b/include/hw/display/edid.h
> @@ -1,7 +1,7 @@
> #ifndef EDID_H
> #define EDID_H
>
> -#include "hw/hw.h"
> +#include "qom/object.h"
>
> typedef struct qemu_edid_info {
> const char *vendor; /* http://www.uefi.org/pnp_id_list */
> diff --git a/include/hw/hw.h b/include/hw/hw.h
> index 8e18358e6a..8079b911fa 100644
> --- a/include/hw/hw.h
> +++ b/include/hw/hw.h
> @@ -6,8 +6,6 @@
> #error Cannot include hw/hw.h from user emulation
> #endif
>
> -#include "qom/object.h"
> -
> void QEMU_NORETURN hw_error(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>
> #endif
>
2560 objects improved by this tiny patch :)
Tested-by: Philippe Mathieu-Daudé <address@hidden>
- Re: [Qemu-devel] [PATCH v2 14/29] migration: Move the VMStateDescription typedef to typedefs.h, (continued)
- [Qemu-devel] [PATCH v2 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h, Markus Armbruster, 2019/08/06
- [Qemu-devel] [PATCH v2 07/29] trace: Do not include qom/cpu.h into generated trace.h, Markus Armbruster, 2019/08/06
- [Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less, Markus Armbruster, 2019/08/06
- Re: [Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 16/29] Include exec/memory.h slightly less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 23/29] numa: Don't include hw/boards.h into sysemu/numa.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 24/29] Include sysemu/hostmem.h less, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 06/29] trace: Eliminate use of TARGET_FMT_plx, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 22/29] Include hw/boards.h a bit less, Markus Armbruster, 2019/08/06