Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

[Philippe Mathieu-Daudé]

On 8/9/19 12:29 PM, Philippe Mathieu-Daudé wrote:
> On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote:
> [...]
>> netmap failing again :S
>>
>> $ make docker-image-debian-amd64 V=1 DEBUG=1
>> [...]
>>   CC      net/netmap.o
>> net/netmap.c: In function 'netmap_update_fd_handler':
>> net/netmap.c:109:5: error: implicit declaration of function
>> 'qemu_set_fd_handler' [-Werror=implicit-function-declaration]
>>      qemu_set_fd_handler(s->nmd->fd,
>>      ^~~~~~~~~~~~~~~~~~~
>> net/netmap.c:109:5: error: nested extern declaration of
>> 'qemu_set_fd_handler' [-Werror=nested-externs]
> 
> Since it might not be obvious to see how helpful/powerful is Docker, I
> gathered few notes (already posted once) about how I use it (often
> bisecting).
> 
> # Automatically create a base image (the image is then cached)
> $ make docker-image-debian-s390x-cross
> 
> # Create a out-of-tree build directory
> $ mkdir build/docker_s390x
> 
> # Run ./configure
> #
> # --rm  : Use a temp copy of the base image (do not modify it)
> # -v ...: Mount the current directory within the container
> # -w ...: Start the shell in the out-of-tree directory
> # -u ...: Use same UID as my user so I can remove the files after
> # $QEMU_CONFIGURE_OPTS contains the cross-compile options
> #
> $ docker run --rm \
>   -v $PWD:$PWD \
>   -w $PWD/build/docker_s390x \
>   -u $UID \
>   qemu:debian-s390x-cross \
>     \
>     sh -c "../../configure \$QEMU_CONFIGURE_OPTS"
> 
> I use 'sh -c' to escape $QEMU_CONFIGURE_OPTS, there might be a cleaner
> way to do this.
> 
> # Stupid step to speed up bisection
> # This will:
> # - clone submodules if necessary
> # - build slirp
> # - build fdt
> # - build capstone
> # - generated bunch of headers
> # - generated bunch of trace files
> $ docker run --rm \
>   -v $PWD:$PWD \
>   -w $PWD/build/docker_s390x \
>   -u $UID \
>   qemu:debian-s390x-cross \
>     \
>     make stubs/qtest.o
> 
> Now the directory is ready for building/bisecting.
> 
> I.e. build a single file:
> 
> $ docker run --rm \
>   -v $PWD:$PWD \
>   -w $PWD/build/docker_s390x \
>   -u $UID \
>   qemu:debian-s390x-cross \
>     \
>     make -C s390x-softmmu hw/intc/s390_flic_kvm.o
> 
> make: Entering directory 'build/docker_s390x/s390x-softmmu'
>   CC      hw/intc/s390_flic_kvm.o
> hw/intc/s390_flic_kvm.c: In function 'kvm_flic_save':
> hw/intc/s390_flic_kvm.c:395:9: error: implicit declaration of function
> 'qemu_put_be64' [-Werror=implicit-function-declaration]
>          qemu_put_be64(f, FLIC_FAILED);
>          ^~~~~~~~~~~~~
> hw/intc/s390_flic_kvm.c:395:9: error: nested extern declaration of
> 'qemu_put_be64' [-Werror=nested-externs]
> hw/intc/s390_flic_kvm.c:410:9: error: implicit declaration of function
> 'qemu_put_buffer' [-Werror=implicit-function-declaration]
>          qemu_put_buffer(f, (uint8_t *) buf,
>          ^~~~~~~~~~~~~~~
> hw/intc/s390_flic_kvm.c:410:9: error: nested extern declaration of
> 'qemu_put_buffer' [-Werror=nested-externs]
> hw/intc/s390_flic_kvm.c: In function 'kvm_flic_load':
> hw/intc/s390_flic_kvm.c:438:13: error: implicit declaration of function
> 'qemu_get_be64' [-Werror=implicit-function-declaration]
>      count = qemu_get_be64(f);
>              ^~~~~~~~~~~~~
> hw/intc/s390_flic_kvm.c:438:5: error: nested extern declaration of
> 'qemu_get_be64' [-Werror=nested-externs]
>      count = qemu_get_be64(f);
>      ^~~~~
> hw/intc/s390_flic_kvm.c:454:9: error: implicit declaration of function
> 'qemu_get_buffer' [-Werror=implicit-function-declaration]
>      if (qemu_get_buffer(f, (uint8_t *) buf, len) != len) {
>          ^~~~~~~~~~~~~~~
> hw/intc/s390_flic_kvm.c:454:5: error: nested extern declaration of
> 'qemu_get_buffer' [-Werror=nested-externs]
>      if (qemu_get_buffer(f, (uint8_t *) buf, len) != len) {
>      ^~
> cc1: all warnings being treated as errors
> rules.mak:69: recipe for target 'hw/intc/s390_flic_kvm.o' failed
> make: *** [hw/intc/s390_flic_kvm.o] Error 1
> make: Leaving directory 'build/docker_s390x/s390x-softmmu'

Oops replied to incorrect thread haha =)

So adapted for amd64:


# Automatically create a base image (the image is then cached)
$ make docker-image-debian-amd64

# Create a out-of-tree build directory
$ mkdir build/docker_amd64

# Run ./configure
#
# --rm  : Use a temp copy of the base image (do not modify it)
# -v ...: Mount the current directory within the container
# -w ...: Start the shell in the out-of-tree directory
# -u ...: Use same UID as my user so I can remove the files after
# $QEMU_CONFIGURE_OPTS contains the cross-compile options
#
$ docker run --rm \
  -v $PWD:$PWD \
  -w $PWD/build/docker_amd64 \
  -u $UID \
  qemu:debian-amd64 \
    \
    sh -c "../../configure \$QEMU_CONFIGURE_OPTS"

I use 'sh -c' to escape $QEMU_CONFIGURE_OPTS, there might be a cleaner
way to do this.

# Stupid step to speed up bisection
# This will:
# - clone submodules if necessary
# - build slirp
# - build fdt
# - build capstone
# - generated bunch of headers
# - generated bunch of trace files
$ docker run --rm \
  -v $PWD:$PWD \
  -w $PWD/build/docker_amd64 \
  -u $UID \
  qemu:debian-amd64 \
    \
    make stubs/qtest.o > /dev/null

Now the directory is ready for building/bisecting.

I.e. build a single file:

$ docker run --rm \
  -v $PWD:$PWD \
  -w $PWD/build/docker_amd64 \
  -u $UID \
  qemu:debian-amd64 \
    \
    make net/netmap.o

  CC      net/netmap.o
net/netmap.c: In function 'netmap_update_fd_handler':
net/netmap.c:109:5: error: implicit declaration of function
'qemu_set_fd_handler' [-Werror=implicit-function-declaration]
     qemu_set_fd_handler(s->nmd->fd,
     ^~~~~~~~~~~~~~~~~~~
net/netmap.c:109:5: error: nested extern declaration of
'qemu_set_fd_handler' [-Werror=nested-externs]
cc1: all warnings being treated as errors
rules.mak:69: recipe for target 'net/netmap.o' failed
make: *** [net/netmap.o] Error 1

Now you can appreciate how powerful Docker can be!

Regards,

Phil.