Re: [Qemu-devel] [PATCH] xhci: Add No Op Command

[Hikaru Nishida]

ping^2

2019年8月6日(火) 0:38 Hikaru Nishida <address@hidden>:

> ping...
>
> 2019年7月20日(土) 15:04 <address@hidden>:
>
>> From: Hikaru Nishida <address@hidden>
>>
>> This commit adds No Op Command (23) to xHC for verifying the operation
>> of the Command Ring mechanisms.
>> No Op Command is defined in XHCI spec (4.6.2) and just reports Command
>> Completion Event with Completion Code == Success.
>> Before this commit, No Op Command is not implemented so xHC reports
>> Command Completion Event with Completion Code == TRB Error. This commit
>> fixes this behaviour to report Completion Code correctly.
>>
>> Signed-off-by: Hikaru Nishida <address@hidden>
>> ---
>>  hw/usb/hcd-xhci.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 5894a18663..5ceff78280 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -2542,6 +2542,9 @@ static void xhci_process_commands(XHCIState *xhci)
>>          case CR_GET_PORT_BANDWIDTH:
>>              event.ccode = xhci_get_port_bandwidth(xhci, trb.parameter);
>>              break;
>> +        case CR_NOOP:
>> +            event.ccode = CC_SUCCESS;
>> +            break;
>>          case CR_VENDOR_NEC_FIRMWARE_REVISION:
>>              if (xhci->nec_quirks) {
>>                  event.type = 48; /* NEC reply */
>> --
>> 2.20.1 (Apple Git-117)
>>
>>