[Qemu-devel] [Bug 1840646] [NEW] qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

[dcb]

Public bug reported:

qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
conjunction always evaluates to false: alen <= 0 && alen >= sizeof(args)
- 1. [incorrectLogicOperator]

Source code is

   if (alen <= 0 && alen >= sizeof(args) - 1) {

Maybe better code:

   if (alen <= 0 || alen >= sizeof(args) - 1) {

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646

Title:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

Status in QEMU:
  New

Bug description:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
  conjunction always evaluates to false: alen <= 0 && alen >=
  sizeof(args) - 1. [incorrectLogicOperator]

  Source code is

     if (alen <= 0 && alen >= sizeof(args) - 1) {

  Maybe better code:

     if (alen <= 0 || alen >= sizeof(args) - 1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions