[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as modu
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module |
|
Date: |
Fri, 23 Aug 2019 11:32:06 +0400 |
On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini <address@hidden> wrote:
>
> $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so
> ui-spice-app is always linked into QEMU.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I would rather build the module:
-common-obj-$(call land,$(CONFIG_SPICE),$(CONFIG_GIO)) += spice-app.mo
+ifeq ($(CONFIG_GIO)$(CONFIG_SPICE),yy)
+common-obj-$(if $(CONFIG_MODULES),m,y) += spice-app.mo
+endif
> ---
> tests/modules-test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index a8118e9..f9de3af 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -53,9 +53,6 @@ int main(int argc, char *argv[])
> #ifdef CONFIG_SDL
> "ui-", "sdl",
> #endif
> -#if defined(CONFIG_SPICE) && defined(CONFIG_GIO)
> - "ui-", "spice-app",
> -#endif
> };
> int i;
>
> --
> 1.8.3.1
>
>
--
Marc-André Lureau