[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured rep
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request |
Date: |
Fri, 23 Aug 2019 11:41:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
[dropping non-qemu lists]
On 8/23/19 9:37 AM, Eric Blake wrote:
> A server may have a reason to reject a request for structured replies,
> beyond just not recognizing them as a valid request. It doesn't hurt
> us to continue talking to such a server; otherwise 'qemu-nbd --list'
> of such a server fails to display all possible details about the
> export.
>
> Encountered when temporarily tweaking nbdkit to reply with
> NBD_REP_ERR_POLICY. Present since structured reply support was first
> added (commit d795299b reused starttls handling, but starttls has to
> reject all errors).
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> nbd/client.c | 39 +++++++++++++++++++++++----------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
Shoot, I included one patch too many. This patch was posted in a
separate thread, where I argued that it is broken and needs a v2:
https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg04323.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] Add NBD fast zero support to qemu client and server, (continued)
- [Qemu-devel] [PATCH 3/5] nbd: Implement client use of NBD FAST_ZERO, Eric Blake, 2019/08/23
- [Qemu-devel] [PATCH 4/5] nbd: Implement server use of NBD FAST_ZERO, Eric Blake, 2019/08/23
- [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request, Eric Blake, 2019/08/23
- Re: [Qemu-devel] [PATCH 5/5] nbd: Tolerate more errors to structured reply request,
Eric Blake <=
- [Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO, Eric Blake, 2019/08/23
- Re: [Qemu-devel] [PATCH 2/5] nbd: Prepare for NBD_CMD_FLAG_FAST_ZERO, Vladimir Sementsov-Ogievskiy, 2019/08/31
Re: [Qemu-devel] [PATCH 0/5] Add NBD fast zero support to qemu client and server, Vladimir Sementsov-Ogievskiy, 2019/08/28
[Qemu-devel] [libnbd PATCH 0/1] libnbd support for new fast zero, Eric Blake, 2019/08/23