Re: [Qemu-devel] [PATCH 13/25] audio: remove hw->samples, buffer_size_in/out pcm_ops

[Gerd Hoffmann]

On Sun, Aug 25, 2019 at 08:46:15PM +0200, Kővágó, Zoltán wrote:
> This patch removes the samples member from HWVoiceIn and HWVoiceOut.
> Backends can specify buffer size via the newly added buffer_size_in and
> buffer_size_out functions in audio_pcm_ops.  They are optional, if not
> defined qemu will fall back to some built-in constant.
> 
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> ---
> 
> Notes:
>     Not sure if this is necessary.  At first it seemed like a good idea to
>     have a function so that backends can compute the size on demand when
>     needed and things like that, but currently it's just a burden.

If none of the backends actually uses this, then drop it.

cheers,
  Gerd