Re: [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm

[Dmitry Fleytman]

> On 22 Aug 2019, at 14:12, Dr. David Alan Gilbert (git) <address@hidden> wrote:
> 
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling
> unregister_savevm call.  Remove it, although it doesn't seem to have
> any bad effect.
> 

Reviewed-by: Dmitry Fleytman <address@hidden>

> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/net/vmxnet3.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index b07adeed9c..39ff6624c5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2242,13 +2242,10 @@ static void vmxnet3_instance_init(Object *obj)
> 
> static void vmxnet3_pci_uninit(PCIDevice *pci_dev)
> {
> -    DeviceState *dev = DEVICE(pci_dev);
>     VMXNET3State *s = VMXNET3(pci_dev);
> 
>     VMW_CBPRN("Starting uninit...");
> 
> -    unregister_savevm(dev, "vmxnet3-msix", s);
> -
>     vmxnet3_net_uninit(s);
> 
>     vmxnet3_cleanup_msix(s);
> -- 
> 2.21.0
>