Re: [Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

[Peter Maydell]

On Fri, 23 Aug 2019 at 15:54, Peter Maydell <address@hidden> wrote:
>
> On Mon, 19 Aug 2019 at 22:38, Richard Henderson
> <address@hidden> wrote:
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> >  target/arm/translate.c | 797 ++++++++++++++++++-----------------------
> >  target/arm/a32.decode  | 120 +++++++
> >  target/arm/t32.decode  | 141 ++++++++
> >  3 files changed, 615 insertions(+), 443 deletions(-)
>
> This one is brutal to review. I got through review of all the
> decode file patterns but got bogged down when I started looking
> at the .c file changes... I might come back to it alter.

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM