[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 1/2] tcg: Make probe_write() return a pointer to the host page |
|
Date: |
Wed, 28 Aug 2019 07:44:17 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/28/19 4:10 AM, David Hildenbrand wrote:
> + * If the access is permitted, returns the host address similar to
> + * tlb_vaddr_to_host(). Returns NULL in case direct access to the host page
> + * is not allowed or if the size is 0.
Maybe we can find some better language -- "not allowed" sounds like a
permissions check, and we longjmp out on permission check failures.
Perhaps "if the page requires i/o access"?
Why are you returning NULL for size 0? Just because the caller hasn't
committed to a size and thus we haven't checked watchpoints?
r~