Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: Test reverse sub-cluster qcow2 writes

[John Snow]

On 8/23/19 9:03 AM, Max Reitz wrote:
> This exercises the regression introduced in commit
> 50ba5b2d994853b38fed10e0841b119da0f8b8e5.  On my machine, it has close
> to a 50 % false-negative rate, but that should still be sufficient to
> test the fix.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/265     | 67 ++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/265.out |  6 ++++
>  tests/qemu-iotests/group   |  1 +
>  3 files changed, 74 insertions(+)
>  create mode 100755 tests/qemu-iotests/265
>  create mode 100644 tests/qemu-iotests/265.out
> 
> diff --git a/tests/qemu-iotests/265 b/tests/qemu-iotests/265
> new file mode 100755
> index 0000000000..dce6f77be3
> --- /dev/null
> +++ b/tests/qemu-iotests/265
> @@ -0,0 +1,67 @@
> +#!/usr/bin/env bash
> +#
> +# Test reverse-ordered qcow2 writes on a sub-cluster level
> +#
> +# Copyright (C) 2019 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +seq=$(basename $0)
> +echo "QA output created by $seq"
> +
> +status=1     # failure is the default!
> +
> +_cleanup()
> +{
> +    _cleanup_test_img
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +# qcow2-specific test
> +_supported_fmt qcow2
> +_supported_proto file
> +_supported_os Linux
> +
> +echo '--- Writing to the image ---'
> +
> +# Reduce cluster size so we get more and quicker I/O
> +IMGOPTS='cluster_size=4096' _make_test_img 1M
> +(for ((kb = 1024 - 4; kb >= 0; kb -= 4)); do \
> +     echo "aio_write -P 42 $((kb + 1))k 2k"; \
> + done) \
> + | $QEMU_IO "$TEST_IMG" > /dev/null
> +
> +echo '--- Verifying its content ---'
> +
> +(for ((kb = 0; kb < 1024; kb += 4)); do \
> +    echo "read -P 0 ${kb}k 1k"; \
> +    echo "read -P 42 $((kb + 1))k 2k"; \
> +    echo "read -P 0 $((kb + 3))k 1k"; \
> + done) \
> + | $QEMU_IO "$TEST_IMG" | _filter_qemu_io | grep 'verification'
> +
> +# Status of qemu-io
> +if [ ${PIPESTATUS[1]} = 0 ]; then
> +    echo 'Content verified.'
> +fi
> +
> +# success, all done
> +echo "*** done"
> +rm -f $seq.full
> +status=0
> diff --git a/tests/qemu-iotests/265.out b/tests/qemu-iotests/265.out
> new file mode 100644
> index 0000000000..6eac620f25
> --- /dev/null
> +++ b/tests/qemu-iotests/265.out
> @@ -0,0 +1,6 @@
> +QA output created by 265
> +--- Writing to the image ---
> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576
> +--- Verifying its content ---
> +Content verified.
> +*** done
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index d95d556414..0c129c1644 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -274,3 +274,4 @@
>  257 rw
>  258 rw quick
>  262 rw quick migration
> +265 rw auto quick
> 

Tested-by: John Snow <address@hidden>
Reviewed-by: John Snow <address@hidden>