[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 05/13] block: move block_copy from block/back
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH v9 05/13] block: move block_copy from block/backup.c to separate file |
Date: |
Thu, 29 Aug 2019 12:00:01 +0000 |
28.08.2019 19:16, Max Reitz wrote:
> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote:
>> Split block_copy to separate file, to be cleanly shared with backup-top
>> filter driver in further commits.
>>
>> It's a clean movement, the only change is drop "static" from interface
>> functions.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> include/block/block-copy.h | 59 +++++++
>> block/backup.c | 313 +------------------------------------
>> block/block-copy.c | 307 ++++++++++++++++++++++++++++++++++++
>> block/Makefile.objs | 1 +
>> block/trace-events | 2 +
>> 5 files changed, 370 insertions(+), 312 deletions(-)
>> create mode 100644 include/block/block-copy.h
>> create mode 100644 block/block-copy.c
>
> May change depending on changes to the preceding patches, but FWIW
>
> Reviewed-by: Max Reitz <address@hidden>
>
If you don't mind, I'll keep it until the patch doing simple nochange movement.
--
Best regards,
Vladimir
- Re: [Qemu-devel] [PATCH v9 01/13] block/backup: fix backup_cow_with_offload for last cluster, (continued)
- [Qemu-devel] [PATCH v9 12/13] block: introduce backup-top filter driver, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 09/13] iotests: 257: drop device_add, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 03/13] block/backup: introduce BlockCopyState, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 05/13] block: move block_copy from block/backup.c to separate file, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 06/13] block: teach bdrv_debug_breakpoint skip filters with backing, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 08/13] iotests: 257: drop unused Drive.device field, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 07/13] iotests: prepare 124 and 257 bitmap querying for backup-top filter, Vladimir Sementsov-Ogievskiy, 2019/08/26
- [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers, Vladimir Sementsov-Ogievskiy, 2019/08/26