[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/8] cputlb: Remove double-alignment in store
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/8] cputlb: Remove double-alignment in store_helper |
Date: |
Thu, 29 Aug 2019 19:00:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/29/19 1:16 AM, Richard Henderson wrote:
> We have already aligned page2 to the start of the next page.
> There is no reason to do that a second time.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> accel/tcg/cputlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index 7fb67d2f05..d0f8db33a2 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -1518,8 +1518,7 @@ store_helper(CPUArchState *env, target_ulong addr,
> uint64_t val,
> entry2 = tlb_entry(env, mmu_idx, page2);
> tlb_addr2 = tlb_addr_write(entry2);
> if (!tlb_hit_page(tlb_addr2, page2)
> - && !victim_tlb_hit(env, mmu_idx, index2, tlb_off,
> - page2 & TARGET_PAGE_MASK)) {
> + && !victim_tlb_hit(env, mmu_idx, index2, tlb_off, page2)) {
> tlb_fill(env_cpu(env), page2, size2, MMU_DATA_STORE,
> mmu_idx, retaddr);
> }
>
- [Qemu-devel] [PATCH v2 1/8] exec: Move user-only watchpoint stubs inline, (continued)
- [Qemu-devel] [PATCH v2 1/8] exec: Move user-only watchpoint stubs inline, Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 2/8] exec: Factor out core logic of check_watchpoint(), Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 3/8] cputlb: Fold TLB_RECHECK into TLB_INVALID_MASK, Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 4/8] exec: Factor out cpu_watchpoint_address_matches, Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 5/8] cputlb: Fix size operand for tlb_fill on unaligned store, Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 6/8] cputlb: Remove double-alignment in store_helper, Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 8/8] tcg: Check for watchpoints in probe_write(), Richard Henderson, 2019/08/28
- [Qemu-devel] [PATCH v2 7/8] cputlb: Handle watchpoints via TLB_WATCHPOINT, Richard Henderson, 2019/08/28