[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/12] gdbstub: Fix handling of '!' packet with new i
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 01/12] gdbstub: Fix handling of '!' packet with new infra |
Date: |
Mon, 2 Sep 2019 11:21:11 +0100 |
From: Ramiro Polla <address@hidden>
Since the '!' packet is not handled by the new infrastructure,
gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser
value, which would lead to an unsupported packet ("$#00") being sent,
which could confuse the gdb client.
This also has a side-effect of speeding up the initial connection with
gdb.
Fixes: 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")
Signed-off-by: Ramiro Polla <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
diff --git a/gdbstub.c b/gdbstub.c
index b92ba59e4df..5c067594bae 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2588,7 +2588,9 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
break;
}
- run_cmd_parser(s, line_buf, cmd_parser);
+ if (cmd_parser) {
+ run_cmd_parser(s, line_buf, cmd_parser);
+ }
return RS_IDLE;
}
--
2.20.1
- [Qemu-devel] [PULL 00/12] fixes for gdbstub, gitdm and testing, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 01/12] gdbstub: Fix handling of '!' packet with new infra,
Alex Bennée <=
- [Qemu-devel] [PULL 03/12] contrib/gitdm: filetype interface is not in order, fix, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 02/12] gdbstub: Fix handler for 'F' packet, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 06/12] mailmap: Update philmd email address, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 04/12] contrib/gitdm: Add address@hidden to group-map-redhat, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 05/12] mailmap: Reorder by sections, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 09/12] contrib/gitdm: Add RT-RK to the domain-map, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 07/12] mailmap: Add many entries to improve 'git shortlog' statistics, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 10/12] build-sys: build ui-spice-app as a module, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 11/12] tests: fix modules-test with no default machine, Alex Bennée, 2019/09/02
- [Qemu-devel] [PULL 08/12] .mailmap/aliases: add some further commentary, Alex Bennée, 2019/09/02