qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf()


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf()
Date: Tue, 10 Sep 2019 10:54:25 +0100

On Tue, 10 Sep 2019 at 10:50, Alex Bennée <address@hidden> wrote:
> Seem sensible enough (although gah, I hate these glue bits). Would the
> large amount of goto fail logic be something that could be cleaned up
> with the automatic cleanup functions we recently mentioned in
> CODING_STYLE.rst?

Probably not, because one bit of cleanup we *should* be doing
in the fail-exit codepaths but currently don't is to delete
any rom blobs we created for earlier segments in the ELF file
before we gave up, so we need to have an error-exit path anyway...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]