[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/15] linux-user: Support gdb 'qOffsets' query for E
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 08/15] linux-user: Support gdb 'qOffsets' query for ELF |
Date: |
Tue, 10 Sep 2019 18:35:53 +0200 |
From: Josh Kunz via Qemu-devel <address@hidden>
This is needed to support debugging PIE ELF binaries running under QEMU
user mode. Currently, `code_offset` and `data_offset` remain unset for
all ELF binaries, so GDB is unable to correctly locate the position of
the binary's text and data.
The fields `code_offset`, and `data_offset` were originally added way
back in 2006 to support debugging of bFMT executables (978efd6aac6),
and support was just never added for ELF. Since non-PIE binaries are
loaded at exactly the address specified in the binary, GDB does not need
to relocate any symbols, so the buggy behavior is not normally observed.
http://sourceware.org/gdb/onlinedocs/gdb/General-Query-Packets.html#index-qOffsets-packet
Buglink: https://bugs.launchpad.net/qemu/+bug/1528239
Signed-off-by: Josh Kunz <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[lv: added link to documentation]
Signed-off-by: Laurent Vivier <address@hidden>
---
linux-user/elfload.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 43c16a846d33..f6693e576098 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2403,6 +2403,8 @@ static void load_elf_image(const char *image_name, int
image_fd,
}
info->load_bias = load_bias;
+ info->code_offset = load_bias;
+ info->data_offset = load_bias;
info->load_addr = load_addr;
info->entry = ehdr->e_entry + load_bias;
info->start_code = -1;
--
2.21.0
- [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 06/15] linux-user: Pass CPUState to MAX_RESERVED_VA, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 10/15] linux-user: drop redundant handling of environment variables, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 04/15] linux-user: fail and report on bad dfilter specs, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 07/15] linux-user/arm: Adjust MAX_RESERVED_VA for M-profile, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 03/15] linux-user: erroneous fd_trans_unregister call, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 01/15] linux-user: remove useless variable, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 02/15] linux-user: Add AT_HWCAP2 for aarch64-linux-user, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 05/15] linux-user: add memfd_create, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 11/15] linux-user: Add support for RNDRESEEDCRNG ioctl, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 08/15] linux-user: Support gdb 'qOffsets' query for ELF,
Laurent Vivier <=
- [Qemu-devel] [PULL 12/15] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 09/15] target/xtensa: linux-user: add call0 ABI support, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 15/15] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 13/15] linux-user: Add support for FDFLUSH ioctl, Laurent Vivier, 2019/09/10
- [Qemu-devel] [PULL 14/15] linux-user: Add support for FDMSGON and FDMSGOFF ioctls, Laurent Vivier, 2019/09/10
- Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches, no-reply, 2019/09/10
- Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches, no-reply, 2019/09/10
- Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches, no-reply, 2019/09/10
- Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches, no-reply, 2019/09/11