[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/16] docs/devel/qapi-code-gen: Reorder sect
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/16] docs/devel/qapi-code-gen: Reorder sections for readability |
Date: |
Tue, 10 Sep 2019 11:36:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/10/19 1:37 AM, Markus Armbruster wrote:
> Section "QMP/Guest agent schema" starts with a brief introduction,
> then subsection "Comments", then subsection "Schema overview" (more
> elaborate introduction), and only then talks about schema entities
> like types, commands, and so forth.
>
> Subsection "Comments" is long and tiring: almost 500 words, mostly
> about doc comments. Move the doc comment part to its own subsection
> "Documentation comments" at the very end of "QMP/Guest agent schema".
>
> Subsection "Schema overview" explains naming rules at considerable
> length: 250 words. Move this part to its own subsection "Naming rules
> and reserved names" right after the subsections on schema entities.
>
> Subsection "Enumeration types" is wedged between "Struct types" and
> "Union types". Move it before "Struct types".
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/devel/qapi-code-gen.txt | 436 ++++++++++++++++++-----------------
> 1 file changed, 221 insertions(+), 215 deletions(-)
Large patch, but mostly just shuffling sections.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 11/16] qapi: Adjust frontend errors to say enum value, not member, (continued)
- [Qemu-devel] [PATCH v2 10/16] qapi: Permit omitting all flat union branches, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 06/16] qapi: Restrict strings to printable ASCII, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 09/16] qapi: Permit alternates with just one branch, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 12/16] docs/devel/qapi-code-gen: Reorder sections for readability, Markus Armbruster, 2019/09/10
- Re: [Qemu-devel] [PATCH v2 12/16] docs/devel/qapi-code-gen: Reorder sections for readability,
Eric Blake <=
- [Qemu-devel] [PATCH v2 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 07/16] qapi: Drop support for escape sequences other than \\, Markus Armbruster, 2019/09/10
- [Qemu-devel] [PATCH v2 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations, Markus Armbruster, 2019/09/10