[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] spapr: Fixes a leak in CAS
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] spapr: Fixes a leak in CAS |
Date: |
Wed, 11 Sep 2019 09:36:38 +0200 |
On Wed, 11 Sep 2019 14:04:48 +1000
David Gibson <address@hidden> wrote:
> From: Alexey Kardashevskiy <address@hidden>
>
> Add a missing g_free(fdt) if the resulting tree is bigger
> than the space allocated by SLOF.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index e03e874d94..d93dacd483 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1024,6 +1024,7 @@ int spapr_h_cas_compose_response(SpaprMachineState
> *spapr,
> _FDT((fdt_pack(fdt)));
>
> if (fdt_totalsize(fdt) + sizeof(hdr) > size) {
> + g_free(fdt);
> trace_spapr_cas_failed(size);
> return -1;
> }
- Re: [Qemu-devel] [PATCH 1/7] spapr: Simplify handling of pre ISA 3.0 guest workaround handling, (continued)