[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate fold
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder |
Date: |
Wed, 11 Sep 2019 10:01:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 11/09/2019 08.58, Kevin Wolf wrote:
> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
>> On 9/10/19 1:58 PM, Thomas Huth wrote:
>>> Our "tests" directory is very overcrowded - we store the qtests,
>>> unit test and other files there. That makes it difficult to
>>> determine which file belongs to each test subsystem, and the
>>> wildcards in the MAINTAINERS file are inaccurate, too.
>>>
>>> Let's clean up this mess. The first patches disentangle some
>>> dependencies, and the last three patches then move the qtests
>>> and libqos (which is a subsystem of the qtests) to a new folder
>>> called "tests/qtest/".
>>
>> I'd also welcome a rename of tests/qemu-iotests to tests/iotests.
>
> I might prefer if the directory were named "iotests" rather than
> "qemu-iotests" if we were only adding the code now.
>
> However, I'm not so sure if I'd like a rename now because a rename
> always comes with a cost and the benefits are rather limited in this
> case.
Well, if we all agree that it rather should be renamed, we should maybe
rather do it now than later. Later the cost might even be higher.
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] Move qtests to a separate folder, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 1/7] tests/Makefile: test-char does not need libqtest, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 2/7] tests/ptimer: Remove unnecessary inclusion of libqtest.h, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 4/7] tests/Makefile: Separate unit test dependencies from qtest dependencies, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 3/7] tests/Makefile: Remove 'tests/' and '$(EXESUF)' from the check-qtest variables, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 7/7] tests/libqos: Move the libqos files under tests/qtest/, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 6/7] tests/Makefile: Move qtest-related settings to a separate Makefile.include, Thomas Huth, 2019/09/10
- [Qemu-devel] [PATCH 5/7] test: Move qtests to a separate directory, Thomas Huth, 2019/09/10
- Re: [Qemu-devel] [PATCH 0/7] Move qtests to a separate folder, Eric Blake, 2019/09/10