|
From: | David Hildenbrand |
Subject: | Re: [Qemu-devel] [PATCH v2 11/28] s390x/tcg: MVCS/MVCP: Properly wrap the length |
Date: | Wed, 11 Sep 2019 18:15:11 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 11.09.19 17:11, Richard Henderson wrote: > On 9/6/19 3:57 AM, David Hildenbrand wrote: >> + l = wrap_length(env, l); >> if (l > 256) { >> /* max 256 */ >> l = 256; >> cc = 3; >> + } else if (!l) { >> + return cc; >> } > > Um, wrap_length only takes 31 bits. > These insns take 32 bits in 24/31-bit modes. Nice observation! Thanks! -- Thanks, David / dhildenb
[Prev in Thread] | Current Thread | [Next in Thread] |