[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_pa
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_part |
Date: |
Fri, 13 Sep 2019 12:01:46 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 16.08.2019 um 17:30 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Further patch will run partial requests of iterations of
> qcow2_co_preadv in parallel for performance reasons. To prepare for
> this, separate part which may be parallelized into separate function
> (qcow2_co_preadv_task).
>
> While being here, also separate encrypted clusters reading to own
> function, like it is done for compressed reading.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> qapi/block-core.json | 2 +-
> block/qcow2.c | 205 +++++++++++++++++++++++--------------------
> 2 files changed, 111 insertions(+), 96 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0d43d4f37c..dd80aa11db 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3266,7 +3266,7 @@
> 'pwritev_rmw_tail', 'pwritev_rmw_after_tail', 'pwritev',
> 'pwritev_zero', 'pwritev_done', 'empty_image_prepare',
> 'l1_shrink_write_table', 'l1_shrink_free_l2_clusters',
> - 'cor_write', 'cluster_alloc_space', 'none'] }
> + 'cor_write', 'cluster_alloc_space', 'none', 'read_encrypted'] }
What's the point of this new blkdebug event?
Obviously, read_aio for an encrypted image must mean a read of encrypted
data. The same image can never trigger both read_aio and
read_encrypted, so why do we need to distinguish them as two different
events?
Kevin
- Re: [Qemu-devel] [PATCH v4 3/5] block/qcow2: refactor qcow2_co_preadv_part,
Kevin Wolf <=