[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 05/16] tests/qapi-schema: Demonstrate bad reporti
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters |
Date: |
Fri, 13 Sep 2019 22:13:38 +0200 |
Invalid name 'not\\possible' is reported as 'not\possible'. Control
characters (quoted or not) are even more confusing. Mark FIXME.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/qapi-schema/enum-bad-name.err | 2 +-
tests/qapi-schema/enum-bad-name.json | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qapi-schema/enum-bad-name.err
b/tests/qapi-schema/enum-bad-name.err
index 9c3c1002b7..26a09f84ad 100644
--- a/tests/qapi-schema/enum-bad-name.err
+++ b/tests/qapi-schema/enum-bad-name.err
@@ -1 +1 @@
-tests/qapi-schema/enum-bad-name.json:2: Member of enum 'MyEnum' uses invalid
name 'not^possible'
+tests/qapi-schema/enum-bad-name.json:3: Member of enum 'MyEnum' uses invalid
name 'not\possible'
diff --git a/tests/qapi-schema/enum-bad-name.json
b/tests/qapi-schema/enum-bad-name.json
index 8506562b31..1c4620edda 100644
--- a/tests/qapi-schema/enum-bad-name.json
+++ b/tests/qapi-schema/enum-bad-name.json
@@ -1,2 +1,3 @@
# we ensure all enum names can map to C
-{ 'enum': 'MyEnum', 'data': [ 'not^possible' ] }
+# FIXME reports 'not\possible' instead of 'not\\possible'
+{ 'enum': 'MyEnum', 'data': [ 'not\\possible' ] }
--
2.21.0
- [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 03/16] qapi: Drop support for boxed alternate arguments, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 04/16] docs/devel/qapi-code-gen: Minor specification fixes, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 01/16] scripts/git.orderfile: Match QAPI schema more precisely, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 06/16] qapi: Restrict strings to printable ASCII, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 07/16] qapi: Drop support for escape sequences other than \\, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema, Markus Armbruster, 2019/09/13