Re: [Qemu-devel] [PATCH v4 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

[Lukas Straub]

On Tue, 10 Sep 2019 20:12:45 +0000
"Zhang, Chen" <address@hidden> wrote:

> > -----Original Message-----
> > From: Lukas Straub <address@hidden>
> > Sent: Tuesday, September 10, 2019 6:15 PM
> > To: qemu-devel <address@hidden>
> > Cc: Zhang, Chen <address@hidden>; Jason Wang
> > <address@hidden>; Wen Congyang <address@hidden>;
> > Xie Changlong <address@hidden>; address@hidden;
> > address@hidden
> > Subject: [PATCH v4 3/4] net/filter.c: Add Options to insert filters 
> > anywhere in
> > the filter list
> >
> > To switch the Secondary to Primary, we need to insert new filters before the
> > filter-rewriter.
> >
> > Add the options insert= and position= to be able to insert filters anywhere 
> > in
> > the filter list.
> >
> > position should be either "head", "tail" or the id of another filter.
>
> In current patch, we cannot distinguish the real "head/tail" or the ID = 
> "head/tail".
> And in real environment we can't order users reserve the "head/tail" as 
> keywords.
> So, I think we can use position=ID-xxxx/head/tail to solve this issue, or do 
> you have any other idea?
>

Hi,
Yes, I will change that.

Regards,
Lukas Straub

> Thanks
> Zhang Chen
>
> > insert should be either "before" or "behind" to specify where to insert the
> > new filter relative to the one specified with position.
> >
> > Signed-off-by: Lukas Straub <address@hidden>
> > ---