[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events |
Date: |
Mon, 16 Sep 2019 18:40:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/16/19 6:36 PM, Eric Blake wrote:
> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote:
>> While the tracing frawework does not forbid trailing newline in
>
> framework
>
>> events format string, using them lead to confuse output.
>> It is the responsibility of the backend to properly end an event
>> line.
>
> Why just trailing newline? Should we not forbid ALL use of newline in a
> trace message?
I thought about it and forgot to add a comment when respining.
Yes, I think this is the right thing to enforce.
However it requires more cleanup, affecting more subsystems, so I'd
rather keep it for a follow-up series.
>>
>> Some of our formats have trailing newlines, remove them.
>>
>> Reviewed-by: John Snow <address@hidden>
>> Reviewed-by: Kevin Wolf <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
[Qemu-devel] [PATCH v2 2/2] trace: Forbid event format ending with newline character, Philippe Mathieu-Daudé, 2019/09/16
Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format, Stefan Hajnoczi, 2019/09/18