[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union branches |
Date: |
Tue, 17 Sep 2019 11:20:36 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/13/19 3:13 PM, Markus Armbruster wrote:
> Absent flat union branches default to the empty struct (since commit
> 800877bb16 "qapi: allow empty branches in flat unions"). But am
s/am/an/
> attempt to omit all of them is rejected with "Union 'FOO' has no
> branches". Harmless oddity, but it's easy to avoid, so do that.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 04/16] docs/devel/qapi-code-gen: Minor specification fixes, (continued)
- [Qemu-devel] [PATCH v3 04/16] docs/devel/qapi-code-gen: Minor specification fixes, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 01/16] scripts/git.orderfile: Match QAPI schema more precisely, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 06/16] qapi: Restrict strings to printable ASCII, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 07/16] qapi: Drop support for escape sequences other than \\, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union branches, Markus Armbruster, 2019/09/13
- Re: [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union branches,
Eric Blake <=
- [Qemu-devel] [PATCH v3 08/16] qapi: Permit 'boxed' with empty type, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 12/16] docs/devel/qapi-code-gen: Reorder sections for readability, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 15/16] docs/devel/qapi-code-gen: Improve QAPI schema language doc, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 09/16] qapi: Permit alternates with just one branch, Markus Armbruster, 2019/09/13
- [Qemu-devel] [PATCH v3 11/16] qapi: Adjust frontend errors to say enum value, not member, Markus Armbruster, 2019/09/13
- Re: [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements, no-reply, 2019/09/14
- Re: [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements, Eric Blake, 2019/09/17
- Re: [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements, Markus Armbruster, 2019/09/23