[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/19] qapi: Simplify check_keys()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 14/19] qapi: Simplify check_keys() |
Date: |
Tue, 17 Sep 2019 14:01:05 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/14/19 10:35 AM, Markus Armbruster wrote:
> check_keys() parameter expr_elem expects a dictionary with keys 'expr'
> and 'info'. Passing the two values separately is simpler, so do that.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi/common.py | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
> -def check_keys(expr_elem, meta, required, optional=[]):
> - expr = expr_elem['expr']
> - info = expr_elem['info']
> +def check_keys(expr, info, meta, required, optional=[]):
> name = expr[meta]
> if not isinstance(name, str):
> raise QAPISemError(info, "'%s' key must have a string value" % meta)
> @@ -1100,40 +1098,39 @@ def check_exprs(exprs):
>
> if 'enum' in expr:
> meta = 'enum'
> - check_keys(expr_elem, 'enum', ['data'], ['if', 'prefix'])
> + check_keys(expr, info, 'enum', ['data'], ['if', 'prefix'])
Works since the caller already separated out the two values in question.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/19] qapi: Frontend fixes and cleanups, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 01/19] tests/qapi-schema: Cover unknown pragma, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 05/19] tests/qapi-schema: Demonstrate insufficient 'if' checking, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 03/19] tests/qapi-schema: Demonstrate misleading optional tag error, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 14/19] qapi: Simplify check_keys(), Markus Armbruster, 2019/09/14
- Re: [Qemu-devel] [PATCH 14/19] qapi: Simplify check_keys(),
Eric Blake <=
- [Qemu-devel] [PATCH 12/19] qapi: Fix missing 'if' checks in struct, union, alternate 'data', Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 10/19] qapi: Fix broken discriminator error messages, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 02/19] tests/qapi-schema: Delete two redundant tests, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 08/19] qapi: Improve reporting of lexical errors, Markus Armbruster, 2019/09/14
- [Qemu-devel] [PATCH 11/19] qapi: Reject blank 'if' conditions in addition to empty ones, Markus Armbruster, 2019/09/14