[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/21] aspeed/soc: Add AST2600 support
From: |
Joel Stanley |
Subject: |
Re: [PATCH 17/21] aspeed/soc: Add AST2600 support |
Date: |
Fri, 20 Sep 2019 04:35:43 +0000 |
On Thu, 19 Sep 2019 at 05:52, Cédric Le Goater <address@hidden> wrote:
>
> Initial definitions for a simple machine using an AST2600 SoC (Cortex
> CPU).
>
> The Cortex CPU and its interrupt controller are too complex to handle
> in the common Aspeed SoC framework. We introduce a new Aspeed SoC
> class with instance_init and realize handlers to handle the differences
> with the AST2400 and the AST2500 SoCs. This will add extra work to
> keep in sync both models with future extensions but it makes the code
> clearer.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Joel Stanley <address@hidden>
One small addition below. If you don't resend I can do a follow up patch for it:
> +
> +static const int aspeed_soc_ast2600_irqmap[] = {
> + [ASPEED_ETH1] = 2,
> + [ASPEED_ETH2] = 3,
We need to add ETH3 and ETH4 here. They look like this:
[ASPEED_ETH3] = 32,
[ASPEED_ETH4] = 33,
- Re: [PATCH 12/21] aspeed/smc: Add AST2600 support, (continued)
- [Qemu-devel] [PATCH 13/21] hw/gpio: Add in AST2600 specific implementation, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 14/21] aspeed/i2c: Introduce an object class per SoC, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 15/21] aspeed/i2c: Add AST2600 support, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 16/21] aspeed: Introduce an object class per SoC, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 17/21] aspeed/soc: Add AST2600 support, Cédric Le Goater, 2019/09/19
- Re: [PATCH 17/21] aspeed/soc: Add AST2600 support,
Joel Stanley <=
- [Qemu-devel] [PATCH 18/21] aspeed: Add an AST2600 eval board, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 19/21] aspeed: Parameterise number of MACs, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 20/21] aspeed: add support for the Aspeed MII controller of the AST2600, Cédric Le Goater, 2019/09/19
- [Qemu-devel] [PATCH 21/21] aspeed/soc: Add ASPEED Video stub, Cédric Le Goater, 2019/09/19
- Re: [Qemu-devel] [PATCH 00/21] aspeed: Add support for the AST2600 SoC, no-reply, 2019/09/19