[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative t
|
From: |
Andrew Jeffery |
|
Subject: |
Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq |
|
Date: |
Fri, 20 Sep 2019 15:44:26 +0930 |
|
User-agent: |
Cyrus-JMAP/3.1.7-238-g170a812-fmstable-20190913v1 |
On Wed, 18 Sep 2019, at 04:55, Richard Henderson wrote:
> On 9/17/19 12:14 PM, Peter Maydell wrote:
> >> +static Property arm_cpu_gt_cntfrq_property =
> >> + DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq,
> >> + (1000 * 1000 * 1000) / GTIMER_SCALE);
> > I think it would be helpful to have a comment saynig what units
> > this property is in.
> >
>
> Should this be NANOSECONDS_PER_SECOND?
> It's certainly a suspicious use of 1e9 otherwise.
You're right that it should be NANOSECONDS_PER_SECOND but
this was just code motion of the definition of the reset value for
CNTFRQ_EL0 in target/arm/helper.c.
Andrew