qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] roms: Add a 'make help' target alias


From: Peter Maydell
Subject: Re: [PATCH] roms: Add a 'make help' target alias
Date: Fri, 20 Sep 2019 18:13:38 +0100

On Fri, 20 Sep 2019 at 18:12, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Various C projects provide a 'make help' target. Our root directory
> does so. The roms/ directory lacks a such rule, but already displays
> a help output when the default target is called.
> Add a 'help' target aliased to the default one, to avoid:
>
>   $ make -C roms help
>   make: *** No rule to make target 'help'.  Stop.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  roms/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 6cf07d3b44..3ffd13cc7e 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -51,7 +51,7 @@ SEABIOS_EXTRAVERSION="-prebuilt.qemu.org"
>  #
>  EDK2_EFIROM = edk2/BaseTools/Source/C/bin/EfiRom
>
> -default:
> +default help:
>         @echo "nothing is build by default"

If you felt like fixing a typo, there's one here: should
be "is built"...

>         @echo "available build targets:"
>         @echo "  bios               -- update bios.bin (seabios)"
> --
> 2.20.1

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]