Re: [PATCH 03/15] ipmi: Generate an interrupt on watchdog pretimeout expiry

[Cédric Le Goater]

On 19/09/2019 23:39, address@hidden wrote:
> From: Corey Minyard <address@hidden>
> 
> Add the watchdog pretimeout to the bits that cause an interrupt on attn.
> Otherwise the user won't know.
> 
> Signed-off-by: Corey Minyard <address@hidden>

Reviewed-by: Cédric Le Goater <address@hidden>

C.

> ---
>  hw/ipmi/ipmi_bmc_sim.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index afb99e33d7..6e6cd1b47d 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -477,7 +477,9 @@ static int attn_set(IPMIBmcSim *ibs)
>  
>  static int attn_irq_enabled(IPMIBmcSim *ibs)
>  {
> -    return (IPMI_BMC_MSG_INTS_ON(ibs) && 
> IPMI_BMC_MSG_FLAG_RCV_MSG_QUEUE_SET(ibs))
> +    return (IPMI_BMC_MSG_INTS_ON(ibs) &&
> +            (IPMI_BMC_MSG_FLAG_RCV_MSG_QUEUE_SET(ibs) ||
> +             IPMI_BMC_MSG_FLAG_WATCHDOG_TIMEOUT_MASK_SET(ibs)))
>          || (IPMI_BMC_EVBUF_FULL_INT_ENABLED(ibs) &&
>              IPMI_BMC_MSG_FLAG_EVT_BUF_FULL_SET(ibs));
>  }
>