[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/11] qcrypto: add suport for amend options
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v2 01/11] qcrypto: add suport for amend options |
Date: |
Mon, 23 Sep 2019 16:24:38 +0300 |
On Mon, 2019-09-23 at 08:08 -0500, Eric Blake wrote:
> On 9/12/19 5:30 PM, Maxim Levitsky wrote:
> > This adds the qcrypto_amend_options and corresponding
> > crypto driver callbacks for the for encrypted
>
> grammar is off, did you miss a word where that double space is?
>
> > key managedment
>
> management
Thank you!
I'll try my best in the future to have less spelling and
grammar errors like that. I need to double check every
message prior to sending the patches.
>
> >
> > Signed-off-by: Maxim Levitsky <address@hidden>
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> > ---
> > crypto/block.c | 31 +++++++++++++++++++++++++++++++
> > crypto/blockpriv.h | 8 ++++++++
> > include/crypto/block.h | 22 ++++++++++++++++++++++
> > 3 files changed, 61 insertions(+)
> >
> > diff --git a/crypto/block.c b/crypto/block.c
> > index 325752871c..14b684de7f 100644
> > --- a/crypto/block.c
> > +++ b/crypto/block.c
> > @@ -115,6 +115,37 @@ QCryptoBlock
> > *qcrypto_block_create(QCryptoBlockCreateOptions *options,
> > }
> >
> >
> > +int qcrypto_block_amend_options(QCryptoBlock *block,
> > + QCryptoBlockReadFunc readfunc,
> > + QCryptoBlockWriteFunc writefunc,
> > + void *opaque,
> > + QCryptoBlockCreateOptions *options,
> > + bool force,
> > + Error **errp)
> > +{
> > + if (options->format != block->format) {
> > + error_setg(errp,
> > + "Its not possible to change encryption format with
> > amend interface");
> > + return -1;
>
> "It's" (here, you want the form meaning "It is")
>
> Or reword the entire error to something shorter:
>
> error_setg(errp, "cannot amend encryption format")
Same here.
>
Thanks for the review,
Best regards,
Maxim Levitsky
- [Qemu-devel] [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 01/11] qcrypto: add suport for amend options, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 03/11] qcrypto-luks: implement the encryption key management, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 04/11] block: amend: add 'force' option, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 05/11] block/crypto: implement the encryption key management, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 02/11] qcrypto-luks: extend the create options for upcoming encryption key management, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 06/11] qcow2: implement crypto amend options, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 07/11] block: add x-blockdev-amend qmp command, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 08/11] block/crypto: implement blockdev-amend, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 09/11] block/qcow2: implement blockdev-amend, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 10/11] iotests: filter few more luks specific create options, Maxim Levitsky, 2019/09/12
- [Qemu-devel] [PATCH v2 11/11] iotests : add tests for encryption key management, Maxim Levitsky, 2019/09/12