[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/20] cputlb: Remove tb_invalidate_phys_page_range is_cpu
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3 18/20] cputlb: Remove tb_invalidate_phys_page_range is_cpu_write_access |
|
Date: |
Mon, 23 Sep 2019 18:50:20 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 23/09/19 18:05, Richard Henderson wrote:
> On 9/23/19 1:52 AM, David Hildenbrand wrote:
>>> - tb_invalidate_phys_page_range__locked(pages, p, start, end,
>>> - is_cpu_write_access);
>>> + tb_invalidate_phys_page_range__locked(pages, p, start, end, 0);
>>
>> I'd prefer "false" to highlight the semantics, but as it's and int ...
>>
>> Reviewed-by: David Hildenbrand <address@hidden>
>
> I did think of that, but then the next patch changes this last argument to
> "uintptr_t retaddr", so then it's not really a boolean argument anymore, and
> "0" is exactly what we want.
Yeah, 0 is fine here.
Paolo
- Re: [PATCH v3 13/20] cputlb: Move NOTDIRTY handling from I/O path to TLB path, (continued)
- [PATCH v3 14/20] cputlb: Partially inline memory_region_section_get_iotlb, Richard Henderson, 2019/09/21
- [PATCH v3 16/20] cputlb: Handle TLB_NOTDIRTY in probe_access, Richard Henderson, 2019/09/21
- [PATCH v3 15/20] cputlb: Merge and move memory_notdirty_write_{prepare, complete}, Richard Henderson, 2019/09/21
- [PATCH v3 17/20] cputlb: Remove cpu->mem_io_vaddr, Richard Henderson, 2019/09/21
- [PATCH v3 18/20] cputlb: Remove tb_invalidate_phys_page_range is_cpu_write_access, Richard Henderson, 2019/09/21
- [PATCH v3 19/20] cputlb: Pass retaddr to tb_invalidate_phys_page_fast, Richard Henderson, 2019/09/21
- [PATCH v3 20/20] cputlb: Pass retaddr to tb_check_watchpoint, Richard Henderson, 2019/09/21
- Re: [PATCH v3 00/20] Move rom and notdirty handling to cputlb, Richard Henderson, 2019/09/22
- Re: [PATCH v3 00/20] Move rom and notdirty handling to cputlb, no-reply, 2019/09/22
- Re: [PATCH v3 00/20] Move rom and notdirty handling to cputlb, David Hildenbrand, 2019/09/23